Skip to content

Gracefully handle unavailable APIs #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2022
Merged

Gracefully handle unavailable APIs #41

merged 3 commits into from
May 21, 2022

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented May 4, 2022 •
edited
Loading

Updating the API to make it compatible with swiftwasm/JavaScriptKit#190.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label May 4, 2022
@MaxDesiatov MaxDesiatov marked this pull request as draft May 4, 2022 11:03
@MaxDesiatov MaxDesiatov mentioned this pull request May 4, 2022
Merged
@MaxDesiatov MaxDesiatov force-pushed the maxd/optional-constructor branch from a5899a1 to 9a5e1c7 Compare May 12, 2022 20:10
@MaxDesiatov MaxDesiatov force-pushed the maxd/optional-constructor branch from ad1808e to ccb3373 Compare May 12, 2022 20:23
@MaxDesiatov MaxDesiatov marked this pull request as ready for review May 20, 2022 15:48
@MaxDesiatov MaxDesiatov requested a review from a team May 20, 2022 15:48
@MaxDesiatov MaxDesiatov merged commit 78ca09c into main May 21, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/optional-constructor branch May 21, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @j-f1